Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Add hit rate #5

Open
bmusuko opened this issue Oct 2, 2020 · 7 comments
Open

Feature - Add hit rate #5

bmusuko opened this issue Oct 2, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest

Comments

@bmusuko
Copy link
Owner

bmusuko commented Oct 2, 2020

Log how many times each shorten link has been visited. You can modify the database to count the hit rate metric

@bmusuko bmusuko added enhancement New feature or request good first issue Good for newcomers Hacktoberfest labels Oct 2, 2020
@kandarppatel28
Copy link
Contributor

Hi @bmusuko , I have gone through your requirement, I would like to work on it, please assign it to me. Thank you.

@bmusuko
Copy link
Owner Author

bmusuko commented Oct 3, 2020

yeah sure @kandarppatel28

@kandarppatel28
Copy link
Contributor

Thank you @bmusuko for assigning it to me, I just have one question, where do we need to log the visited count?

@bmusuko
Copy link
Owner Author

bmusuko commented Oct 3, 2020

I think for now just save the visited count on the database. You can add new schema in database or modify existing schema to store the visited count. For the next enhancement, we can create a dashboard to visualize the data. Let me know if you have any ideas or suggestions

kandarppatel28 added a commit to kandarppatel28/shortener that referenced this issue Oct 3, 2020
@kandarppatel28
Copy link
Contributor

Hi @bmusuko , I have changed the schema, added visitCount and increment it on each link visit. I will brainstorm for sure, that how can we display the visit count. I feel dashboard will be a good idea, we can append a table at the bottom of the existing UI, and show the visit count and also give option for sharing each link.

bmusuko added a commit that referenced this issue Oct 3, 2020
@bmusuko
Copy link
Owner Author

bmusuko commented Oct 3, 2020

I kinda doubt this approach. If we show total visited count when users generating the link, will it always be 0? because the link has just been created. Let me know if I'm missing your point @kandarppatel28 .

@kandarppatel28
Copy link
Contributor

You got me right, I will elaborate it a bit, basically 4 columns

Original Link
Short Link
Visit Count
Share
Whenever a short link is generated, it is appended to the table with Visit Count 0 with options for sharing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants