fix: review feedback 1

bmazzarol · Jan 8, 2025 · f8db8a1 · f8db8a1
1 parent 369b691
commit f8db8a1
Show file tree

Hide file tree

Showing 12 changed files with 36 additions and 36 deletions.
diff --git a/Tuxedo.SourceGenerator/Generators/RefinementSourceGenerator.SingleRefinedTypeSource.cs b/Tuxedo.SourceGenerator/Generators/RefinementSourceGenerator.SingleRefinedTypeSource.cs
@@ -157,7 +157,7 @@ public static bool TryParse(
                         return true;
                     }
                     
-                    refined = default!;
+                    refined = default;
                     failureMessage = {{(model.PredicateReturnsFailureMessage ? "fm" : $"${model.FailureMessage}")}};
                     return false;
                 }
@@ -208,9 +208,9 @@ public override int GetHashCode()
 
     private const string FormattingMembers = """
         /// <inheritdoc />
-            public override string? ToString()
+            public override string ToString()
             {
-                return _value?.ToString();
+                return _value?.ToString() ?? string.Empty;
             }
         """;
 }
diff --git a/Tuxedo.Tests/BoolRefinementsTests.Case4#FalseBool.g.verified.cs b/Tuxedo.Tests/BoolRefinementsTests.Case4#FalseBool.g.verified.cs
@@ -78,7 +78,7 @@ public static bool TryParse(
             return true;
         }
 
-        refined = default!;
+        refined = default;
         failureMessage = $"The boolean value must be 'False', instead found '{value}'";
         return false;
     }
@@ -114,8 +114,8 @@ public override int GetHashCode()
     }
 
     /// <inheritdoc />
-    public override string? ToString()
+    public override string ToString()
     {
-        return _value?.ToString();
+        return _value?.ToString() ?? string.Empty;
     }
 }
diff --git a/Tuxedo.Tests/BoolRefinementsTests.Case5#TrueBool.g.verified.cs b/Tuxedo.Tests/BoolRefinementsTests.Case5#TrueBool.g.verified.cs
@@ -78,7 +78,7 @@ public static bool TryParse(
             return true;
         }
 
-        refined = default!;
+        refined = default;
         failureMessage = $"The boolean value must be 'True', instead found '{value}'";
         return false;
     }
@@ -114,8 +114,8 @@ public override int GetHashCode()
     }
 
     /// <inheritdoc />
-    public override string? ToString()
+    public override string ToString()
     {
-        return _value?.ToString();
+        return _value?.ToString() ?? string.Empty;
     }
 }
diff --git a/Tuxedo.Tests/ConfigureRefinementTypesExample.Case1#Case3.g.verified.cs b/Tuxedo.Tests/ConfigureRefinementTypesExample.Case1#Case3.g.verified.cs
@@ -78,7 +78,7 @@ public static bool TryParse(
             return true;
         }
 
-        refined = default!;
+        refined = default;
         failureMessage = fm;
         return false;
     }
@@ -114,8 +114,8 @@ public override int GetHashCode()
     }
 
     /// <inheritdoc />
-    public override string? ToString()
+    public override string ToString()
     {
-        return _value?.ToString();
+        return _value?.ToString() ?? string.Empty;
     }
 }
diff --git a/Tuxedo.Tests/ConfigureRefinementTypesExample.Case2#Case4.g.verified.cs b/Tuxedo.Tests/ConfigureRefinementTypesExample.Case2#Case4.g.verified.cs
@@ -78,7 +78,7 @@ public static bool TryParse(
             return true;
         }
 
-        refined = default!;
+        refined = default;
         failureMessage = $"Must be true";
         return false;
     }
@@ -114,8 +114,8 @@ public override int GetHashCode()
     }
 
     /// <inheritdoc />
-    public override string? ToString()
+    public override string ToString()
     {
-        return _value?.ToString();
+        return _value?.ToString() ?? string.Empty;
     }
 }
diff --git a/Tuxedo.Tests/CustomAccessModifierTests.Case2#WhiteSpaceChar.g.verified.cs b/Tuxedo.Tests/CustomAccessModifierTests.Case2#WhiteSpaceChar.g.verified.cs
@@ -78,7 +78,7 @@ public static bool TryParse(
             return true;
         }
 
-        refined = default!;
+        refined = default;
         failureMessage = $"`{value}` is not a whitespace character";
         return false;
     }
@@ -114,8 +114,8 @@ public override int GetHashCode()
     }
 
     /// <inheritdoc />
-    public override string? ToString()
+    public override string ToString()
     {
-        return _value?.ToString();
+        return _value?.ToString() ?? string.Empty;
     }
 }
diff --git a/Tuxedo.Tests/CustomTypeRefinementTests.Case3#ValidWidget.g.verified.cs b/Tuxedo.Tests/CustomTypeRefinementTests.Case3#ValidWidget.g.verified.cs
@@ -78,7 +78,7 @@ public static bool TryParse(
             return true;
         }
 
-        refined = default!;
+        refined = default;
         failureMessage = $"The widget must have a valid Id and Name";
         return false;
     }
@@ -114,8 +114,8 @@ public override int GetHashCode()
     }
 
     /// <inheritdoc />
-    public override string? ToString()
+    public override string ToString()
     {
-        return _value?.ToString();
+        return _value?.ToString() ?? string.Empty;
     }
 }
diff --git a/Tuxedo.Tests/DateOnlyExample.Case3#DateOnlyString.g.verified.cs b/Tuxedo.Tests/DateOnlyExample.Case3#DateOnlyString.g.verified.cs
@@ -96,7 +96,7 @@ public static bool TryParse(
             return true;
         }
 
-        refined = default!;
+        refined = default;
         failureMessage = $"The value must be a valid date, but was '{value}'";
         return false;
     }
@@ -132,9 +132,9 @@ public override int GetHashCode()
     }
 
     /// <inheritdoc />
-    public override string? ToString()
+    public override string ToString()
     {
-        return _value?.ToString();
+        return _value?.ToString() ?? string.Empty;
     }
 
     /// <summary>

diff --git a/Tuxedo.Tests/GuidStringTests.Case3#GuidString.g.verified.cs b/Tuxedo.Tests/GuidStringTests.Case3#GuidString.g.verified.cs
@@ -96,7 +96,7 @@ public static bool TryParse(
             return true;
         }
 
-        refined = default!;
+        refined = default;
         failureMessage = $"The value must be a valid GUID, but was '{value}'";
         return false;
     }
@@ -132,9 +132,9 @@ public override int GetHashCode()
     }
 
     /// <inheritdoc />
-    public override string? ToString()
+    public override string ToString()
     {
-        return _value?.ToString();
+        return _value?.ToString() ?? string.Empty;
     }
 
     /// <summary>

diff --git a/Tuxedo.Tests/OddNumberExample.Case4#Odd.g.verified.cs b/Tuxedo.Tests/OddNumberExample.Case4#Odd.g.verified.cs
@@ -79,7 +79,7 @@ public static bool TryParse(
             return true;
         }
 
-        refined = default!;
+        refined = default;
         failureMessage = $"The number must be an odd number, but was '{value}'";
         return false;
     }
@@ -115,8 +115,8 @@ public override int GetHashCode()
     }
 
     /// <inheritdoc />
-    public override string? ToString()
+    public override string ToString()
     {
-        return _value?.ToString();
+        return _value?.ToString() ?? string.Empty;
     }
 }
diff --git a/Tuxedo.Tests/OddNumberExample.Case5#Odd.g.verified.cs b/Tuxedo.Tests/OddNumberExample.Case5#Odd.g.verified.cs
@@ -80,7 +80,7 @@ public static bool TryParse(
             return true;
         }
 
-        refined = default!;
+        refined = default;
         failureMessage = $"The number must be an odd number, but was '{value}'";
         return false;
     }
@@ -116,8 +116,8 @@ public override int GetHashCode()
     }
 
     /// <inheritdoc />
-    public override string? ToString()
+    public override string ToString()
     {
-        return _value?.ToString();
+        return _value?.ToString() ?? string.Empty;
     }
 }
diff --git a/Tuxedo.Tests/PasswordStringExampleTests.Case2#PasswordString.g.verified.cs b/Tuxedo.Tests/PasswordStringExampleTests.Case2#PasswordString.g.verified.cs
@@ -78,7 +78,7 @@ public static bool TryParse(
             return true;
         }
 
-        refined = default!;
+        refined = default;
         failureMessage = $"The string must be at least 8 characters long, contain at most 1 uppercase letter, number and special character. You provided '{value}'.";
         return false;
     }
@@ -114,8 +114,8 @@ public override int GetHashCode()
     }
 
     /// <inheritdoc />
-    public override string? ToString()
+    public override string ToString()
     {
-        return _value?.ToString();
+        return _value?.ToString() ?? string.Empty;
     }
 }