Config.launch now supports defining launch_cls
entry_points per alias
#77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If launching houdini using hab-gui using
habw.exe gui launch
, houdini would not be able to print. The stdout/stderror objects will not accept write's.This seems to be happening because Launcher uses
subprocess.PIPE
to capture stdout/stderr. Switching to the normalsubprocess.Popen
class instead fixes houdini.Checklist
Types of Changes
Proposed Changes
This PR makes it so we can define a per-alias launcher class.
Example .hab.json for houdini: