Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extra config steps for running IOCs on macOS #129

Closed
wants to merge 2 commits into from

Conversation

hyperrealist
Copy link

Adds instructions to circumvent issue #128

Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @hyperrealist! I'll try to run it locally later, just wanted to add a couple of notes:

  • I like the grep -o option, very useful to extract the matching substring only.
  • xargs seems very useful for formatting the inputs and arranging output in columns :)
  • a great solution to add multiple aliases to the loopback interface. I think we can also suggest cleaning up them with -alias if people want to clean the configuration after running the tutorial.

Adds extra instructions related to issue bluesky#128
@hyperrealist
Copy link
Author

I think adding an optional cleanup step is a neat idea. I added a commit to the PR.

@mrakitin
Copy link
Member

Good additions, @hyperrealist! I think it will also be very beneficial to users to have these commands in a shell script so that they can be executed easier. But it's an optional suggestion.

@hyperrealist
Copy link
Author

@mrakitin, I think a better approach might be to wrap start_supervisor.sh around functionality that does the loopback interface configuration automatically if it is invoked on a macOS system. That way, there will be no extra steps for macOS users. What do you think about that?

@mrakitin
Copy link
Member

Good idea, let's try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants