Issue799 #800
Merged
Issue799 #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiled/catalog/adapter.py
Outdated
| @@ -1330,6 +1330,7 @@ def in_memory( | |||
| access_policy=access_policy, | |||
| writable_storage=writable_storage, | |||
| readable_storage=readable_storage, | |||
| init_if_not_exists=True, | |||
There was a problem hiding this comment.
This is not necessary. When the database is in memory, the tables are always initialized because by definition this is a new database in process memory. This keyword argument has the effect of spawning a subprocess to initialize a database, which cannot help in this case.
There was a problem hiding this comment.
Removed. Oops.
dylanmcreynolds
force-pushed
the
issue799
branch
2 times, most recently
from
1bcd028
to
f95bb44
Compare
danielballan
approved these changes
Nov 1, 2024
danielballan
force-pushed
the
issue799
branch
from
852ef91
to
471ee46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Fixes #799
Add a check for the
openpyxclmodule when importing the excel serializer.This was found when trying to run the
tiled[minimal-server]installation. A true test of this would involve creating an environment with just this setup. I think this is something that pixi makes easier, but would be a big change to current CI.A valid question might be: is
minimal-serverever used and could it be excised?