Make HDFPandA StandardDetector #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evalott100
changed the title
PandAController
evalott100
force-pushed
the
127_rename_panda_to_hdfpanda_1
branch
5 times, most recently
from
0827daa
to
1caca7a
Compare
evalott100
force-pushed
the
127_rename_panda_to_hdfpanda_1
branch
7 times, most recently
from
d78ffcb
to
48f1a4e
Compare
Merged
evalott100
force-pushed
the
127_rename_panda_to_hdfpanda_1
branch
8 times, most recently
from
4726e7e
to
15a29b0
Compare
evalott100
force-pushed
the
127_rename_panda_to_hdfpanda_1
branch
4 times, most recently
from
6875883
to
00794f5
Compare
evalott100
force-pushed
the
127_rename_panda_to_hdfpanda_1
branch
3 times, most recently
from
c93c056
to
68b6c8d
Compare
|
@evalott100 docs are breaking for some reason |
Seems to be the same problem as - |
abbiemery
reviewed
Apr 17, 2024
There was a problem hiding this comment.
It looks good from what I can see. The format of the standard detector looks about right but i've not got much of the oversight on panda behaviour to know about it. I'd say get @coretl to approve. I'm leaning to just getting it merged and we'll iron out issues after the next Tuesday test, then we can get a release on its way finally.
evalott100
force-pushed
the
127_rename_panda_to_hdfpanda_1
branch
5 times, most recently
from
5f90bb8
to
940da7d
Compare
evalott100
force-pushed
the
127_rename_panda_to_hdfpanda_1
branch
from
940da7d
to
b1d892a
Compare
Also made it possible to pre-intialise blocks so that the controller can have the same pcap device as the post init panda.
evalott100
force-pushed
the
127_rename_panda_to_hdfpanda_1
branch
from
b1d892a
to
fd0a6d1
Compare
evalott100
force-pushed
the
127_rename_panda_to_hdfpanda_1
branch
from
fd0a6d1
to
5c48c40
Compare
coretl
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #127
Requires #198