Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test helpers for assering value, reading and configuration #199

Closed
callumforrester opened this issue Apr 12, 2024 · 2 comments · Fixed by #226
Closed

Test helpers for assering value, reading and configuration #199

callumforrester opened this issue Apr 12, 2024 · 2 comments · Fixed by #226
Assignees
Labels
hackathon Good issues for the upcoming bluesky hackathon

Comments

@callumforrester
Copy link
Contributor

Dodal developers have produced various useful ways to test ophyd-async devices such as verify(). Some of these should probably make it back into main and sit alongside other helper functions like set_sim_signal.

I think we need 3 helper functions:

  • assert_value(signal: SignalR[T], value: T)
  • assert_reading(readable: Readable, reading: Reading)
  • assert_configuration(readable: Readable, configuration: Configuration)

Acceptance Criteria

  • Functions in ophyd-async
  • Tests provided
  • Docs provided where appropriate
  • Issues raised in dodal to replace verefy() and any other old functions that can be superseded
@callumforrester callumforrester added the hackathon Good issues for the upcoming bluesky hackathon label Apr 12, 2024
@callumforrester
Copy link
Contributor Author

@coretl

@coretl
Copy link
Collaborator

coretl commented Apr 15, 2024

Possibly also want assert_emitted from #206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hackathon Good issues for the upcoming bluesky hackathon
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants