Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: README consistency updates for blues.dev parsing #161

Merged
merged 18 commits into from
Nov 9, 2023

Conversation

tjvantoll
Copy link
Contributor

@tjvantoll tjvantoll commented Nov 3, 2023

Problem Context

We are planning on ingesting the READMEs in this repo directly into the blues.dev documentation, and doing so is way easier if these READMEs are consistent for simpler parsing.

Changes

This PR makes several changes for consistency:

  • No table of contents. The blues.dev UI will have the TOC automatically, and having to manually remove a TOC from Markdown content is tricky.
  • All images must live in an images or assets folder within the project. This makes it easier for us to rework the relative URL into one that will work when rendered on blues.dev.
  • No <p> or <img> tags. Non-Markdown elements are much harder to parse.

Any other related PRs

https://github.com/blues/blues.dev/pull/1442

Ticket(s)

https://trello.com/c/ZqHmDvOe/511-accelerators-embed-full-project-instructions-from-github

@tjvantoll tjvantoll requested a review from rdlauer November 6, 2023 15:31
@tjvantoll tjvantoll merged commit 94b459b into main Nov 9, 2023
17 of 18 checks passed
@tjvantoll tjvantoll deleted the tj-readme-pass branch November 9, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants