Skip to content
This repository has been archived by the owner on Jun 30, 2023. It is now read-only.

Fixed bug that was leading to failure in avro format #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ashishmalgawa
Copy link

@ashishmalgawa ashishmalgawa commented May 8, 2020

If you have a protobuf file like this
MessageA{
MessageB hello = 1;
}
MessageB{
MessageC hello = 1;
}
MessageC{
String abc =1;
}

Then this would result in an error in avro converter, since in the current code the name of the schema for MessageB and MessageC will be Hello.
I've changed the name of the schema, now it will contain the name of the Message Type instead of the fieldname.

@ashishmalgawa ashishmalgawa requested a review from a team as a code owner May 8, 2020 07:56
@abhishekagarwal87
Copy link

Can this be reviewed/merged? It will make it easy to work with large schemas where potential of name collision is high.

@prokopiff
Copy link

I faced this issue too, and this PR fixes it. Is this project still supported? Can we get this merged?

@mdering
Copy link
Contributor

mdering commented Jun 30, 2023

hi, thanks for your interest. We're archiving the repo, you can find a good replacement here https://www.confluent.io/hub/confluentinc/kafka-connect-protobuf-converter

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants