Usability refactor #118
Merged
Usability refactor #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a large change that enables a few changes later on: 1) transport is no longer swappable. This means we will only support the UART HCI transport for now. This is done to remove code and better handle errors. 2) BlueHeron is now it's own Application with it's own supervision structure. This enables robust error handling for Peripherals. 3) Enable SMP by default. This is a noop in the case of non-permissions enabled services, but allows encryption by supplying permissions.
|
I've marked this PR as ready for review for anyone watching. It's a rather large set of changes, so i do apologize for that, but i think it's been long enough that the public APIs needed defining and this is a step in that direction. |
|
I've been using this in anger for the last week or so. Going to merge as it sits to keep moving forward. If anyone finds any problems, feel free to open up an issue and i'll address. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress PR that addresses a handful of larger issues with BlueHeron. Of note, several things will change when this PR is complete
:blue_heronis now an application as opposed to a library. This is done to better use supervision:blue_heron_transport_uartwill be depreciated. This could be seen as a small regression, however to my knowledge, there isn't anyone using the "pluggable" transports as of right now. Please speak up if this isn't true. The reason for this change is just to simplify and reduce code.Peripheralwill now be supervised and backed byPropertyTableinstead of existing only in process memory. This solves a couple problems, and enables a few new features. Notably, Peripheral code is now allowed to crash "safely" without bringing down entire applications, or requiring the entire bluetooth stack to be restarted. This also enabled "readvertising" when a device disconnects without user code needing to implement it.Centralshould now be easier, tho out of the scope of the initial changes in this PR.Closes #26