Remove Unneeded logging features

README.md

@@ -68,37 +68,6 @@ and
 [BlueHeronTransportUSB](https://github.com/blue-heron/blue_heron_transport_usb)
 for examples.
 
-## HCI Logging
-
-This project includes a Logger backend to dump PKTLOG format. This is the same format
-that Android, IOS, btstack, hcidump, and bluez use.
-
-Add the backend to debug all data to/from the HCI transport:
-
-```elixir
-iex> Logger.add_backend(BlueHeron.HCIDump.Logger)
-BlueHeron.HCIDump.Logger
-```
-
-This will produce a file `/tmp/hcidump.pklg` that can be loaded into Wireshark.
-
-**NOTE** This project configures logger so it is always enabled by default.
-However, this can be disabled by setting `config :blue_heron, log_hci_dump_file:
-false`
-
-The `BlueHeron.HCIDump.Logger` module implements a superset of Elixir's builtin logger and
-all non-HCI data is forwarded directly to Elixir's Logger.
-
-```elixir
-iex> require BlueHeron.HCIDump.Logger, as: Logger
-BlueHeron.HCIDump.Logger
-iex> Logger.debug("sample data")
-
-16:43:46.496 [debug] sample data
-
-iex>
-```
-
 ## Helpful docs
 
 * [Bluetooth Core Specification v5.2](https://www.bluetooth.org/docman/handlers/downloaddoc.ashx?doc_id=478726)

lib/blue_heron/hci/transport.ex

@@ -4,6 +4,8 @@ defmodule BlueHeron.HCI.Transport do
   a physical link that implements the callbacks in this module
   """
 
+  require Logger
+
   alias BlueHeron.HCI.Command.{
     ControllerAndBaseband,
     InformationalParameters,
@@ -59,8 +61,6 @@ defmodule BlueHeron.HCI.Transport do
             handlers: [],
             max_error_count: @default_max_error_count
 
-  require BlueHeron.HCIDump.Logger, as: Logger
-
   @type config :: map()
   @type recv_fun :: (binary -> any())
   @callback start_link(config, recv_fun) :: GenServer.on_start()
@@ -155,8 +155,6 @@ defmodule BlueHeron.HCI.Transport do
   end
 
   def prepare(:info, {:transport_data, <<0x4, hci::binary>>}, data) do
-    Logger.hci_packet(:HCI_EVENT_PACKET, :in, hci)
-
     case handle_hci_packet(hci, data) do
       {:ok, %CommandComplete{}, data} ->
         actions = [{:next_event, :internal, :init}]
@@ -193,7 +191,6 @@ defmodule BlueHeron.HCI.Transport do
 
     case module.send_command(pid, command) do
       true ->
-        Logger.hci_packet(:HCI_COMMAND_DATA_PACKET, :out, command)
         prepare(:internal, :init, %{data | init_commands: rest})
 
       false ->
@@ -217,7 +214,6 @@ defmodule BlueHeron.HCI.Transport do
 
     case module.send_command(pid, bin) do
       true ->
-        Logger.hci_packet(:HCI_COMMAND_DATA_PACKET, :out, bin)
         {:keep_state, add_call(data, {from, opcode})}
 
       false ->
@@ -243,7 +239,6 @@ defmodule BlueHeron.HCI.Transport do
 
     case module.send_acl(pid, acl) do
       true ->
-        Logger.hci_packet(:HCI_ACL_DATA_PACKET, :out, acl)
         {:keep_state, data, [{:reply, from, :ok}]}
 
       false ->
@@ -261,8 +256,6 @@ defmodule BlueHeron.HCI.Transport do
   end
 
   def ready(:info, {:transport_data, <<0x4, hci::binary>>}, data) do
-    Logger.hci_packet(:HCI_EVENT_PACKET, :in, hci)
-
     case handle_hci_packet(hci, data) do
       {:ok, %CommandComplete{} = reply, data} ->
         {actions, data} = maybe_reply(data, reply)
@@ -290,7 +283,6 @@ defmodule BlueHeron.HCI.Transport do
   end
 
   def ready(:info, {:transport_data, <<0x2, acl::binary>>}, data) do
-    Logger.hci_packet(:HCI_ACL_DATA_PACKET, :in, acl)
     acl = BlueHeron.ACL.deserialize(acl)
     for pid <- data.handlers, do: send(pid, {:HCI_ACL_DATA_PACKET, acl})
     :keep_state_and_data