Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(sketch) extend Lucene's FirstPassGroupingCollector and SearchGroup for Solr's group.skip.second.step use #232

Open
wants to merge 7 commits into
base: SOLR-11831
Choose a base branch
from
Open

(sketch) extend Lucene's FirstPassGroupingCollector and SearchGroup for Solr's group.skip.second.step use #232

wants to merge 7 commits into from

Conversation

cpoerschke
Copy link
Member

  • presume LUCENE-8728 changes or equivalent are available
  • add SkipSecondPassFirstPassGroupingCollector and (inner) SolrSearchGroup classes
  • on the group.skip.second.step code paths always have SkipSecondPassFirstPassGroupingCollector instead of FirstPassGroupingCollector (and thus SolrSearchGroup which is SearchGroup plus extra info to allow skipping of the second pass)

@cpoerschke cpoerschke mentioned this pull request Dec 10, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpoerschke @diegoceccarelli