Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve uvx when using a git client or IDE #98

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

lamchau
Copy link
Collaborator

@lamchau lamchau commented Sep 26, 2024

When using a client and/or IDE with git integration built in, it's difficult to see a failed ruff commands until after a commit is pushed up. This change adds the ability to see those errors in your client and/or editors if you have the pre-commit hooks installed.

Note: This is purely opt-in (just install-hooks) and a user can bypass with --no-verify after it's installed. n.b. this pre-commit hook does have the potential to "lose" a commit message but many clients save the most recent commit (.git/COMMIT_EDITMSG) but this is generally a bug with the git client/implementation itself.

git-fork

Before

image

After

image

lazygit

image

@lamchau lamchau merged commit aa70408 into block:main Sep 30, 2024
2 checks passed
@lamchau lamchau deleted the lam/commit-hooks branch September 30, 2024 21:30
lukealvoeiro added a commit that referenced this pull request Oct 9, 2024
* main: (41 commits)
  chore: Add goose providers list command (#116)
  docs: working ollama for desktop (#125)
  docs: format and clean up warnings/errors (#120)
  docs: update deploy workflow (#124)
  feat: Implement a goose run command (#121)
  feat: saved api_key to keychain for user (#104)
  docs: add callout plugin (#119)
  chore: add a page to docs for Goose application examples (#117)
  fix: exit the goose and show the error message when provider environment variable is not set (#103)
  fix: Update OpenAI pricing per https://openai.com/api/pricing/ (#110)
  fix: update developer tool prompts to use plan task status to match allowable statuses update_plan tool call (#107)
  fix: removed the panel in the output so that the user won't have unnecessary pane borders in the copied content (#109)
  docs: update links to exchange to the new location (#108)
  chore: setup workspace for exchange (#105)
  fix: resolve uvx when using a git client or IDE (#98)
  ci: add include-markdown for mkdocs (#100)
  chore: fix broken badge on readme (#102)
  feat: add global optional user goosehints file (#73)
  docs: update docs (#99)
  chore(release): release 0.9.3 (#97)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants