feat: port over nondeveloper system into mcp server #561
Conversation
Introduces a trait alias to make that easier across the code base too
wendytang
changed the title
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
wendytang
requested review from
michaelneale,
kalvinnchau,
salman1993,
baxen and
Kvadratni
There was a problem hiding this comment.
@wendytang looks good I think - can you test it out in GUI by adding it to https://github.com/block/goose/blob/v1.0/ui/desktop/src/ChatWindow.tsx#L330 and checking it works as you expect? If that is ok, then this looks great!
| use tokio::io::{stdin, stdout}; | ||
|
|
||
| pub async fn run_server(name: &str) -> Result<()> { | ||
| tracing::info!("Starting MCP server"); | ||
|
|
||
| let router = match name { | ||
| "developer" => Some(RouterService(DeveloperRouter::new())), | ||
| let router: Option<Box<dyn BoundedService>> = match name { |
There was a problem hiding this comment.
@wendytang just wanted to confirm - this means that both cli and GUI can enable the toolkit if they want via the standard way?
There was a problem hiding this comment.
good q, was going to try tackling enablement as a follow-up. the nondeveloper server as it stands here is off by default
* v1.0: feat: Implement a simplified reference agent and dev toolkit (#564) fix: sanitize server names for passing into model tool calls (#563) added a new mcp system + refactor to support it (#552) feat: port over nondeveloper system into mcp server (#561) fix: check server capability when client sends requests (#558) fix: update instructions (#557)
caching:
websearch:
note: