Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework agents to use MCP #546

Merged
merged 14 commits into from
Jan 7, 2025
Merged

Rework agents to use MCP #546

merged 14 commits into from
Jan 7, 2025

Conversation

baxen
Copy link
Collaborator

@baxen baxen commented Jan 6, 2025

No description provided.

Copy link

github-actions bot commented Jan 6, 2025

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

})
}
}

// Manual Clone implementation since we know ProviderConfig variants can be cloned
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally this wouldn't be needed - was able to get rid of it on v1.0

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -306,7 +304,8 @@ async fn handler(
Err(_) => { // Heartbeat, used to detect disconnected clients and then end running tools.
if tx.is_closed() {
// Kill any running processes when the client disconnects
goose::process_store::kill_processes();
// TODO is this used? I suspect post MCP this is on the server instead
// goose::process_store::kill_processes();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baxen wonder if this caused some process hassles you had earlier?

Copy link

github-actions bot commented Jan 7, 2025

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

Copy link

github-actions bot commented Jan 7, 2025

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

Copy link

github-actions bot commented Jan 7, 2025

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

Copy link

github-actions bot commented Jan 7, 2025

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

Copy link

github-actions bot commented Jan 7, 2025

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

@baxen baxen merged commit 82808ab into v1.0 Jan 7, 2025
5 of 6 checks passed
lily-de pushed a commit that referenced this pull request Jan 8, 2025
Co-authored-by: Salman Mohammed <[email protected]>
Co-authored-by: Wendy Tang <[email protected]>
Co-authored-by: Zaki Ali <[email protected]>
Co-authored-by: Kalvin Chau <[email protected]>
Co-authored-by: Mic Neale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants