-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework agents to use MCP #546
Conversation
Co-authored-by: Salman Mohammed <[email protected]>
Co-authored-by: Zaki Ali <[email protected]> Co-authored-by: Salman Mohammed <[email protected]> Co-authored-by: Kalvin Chau <[email protected]>
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
crates/goose-server/src/state.rs
Outdated
}) | ||
} | ||
} | ||
|
||
// Manual Clone implementation since we know ProviderConfig variants can be cloned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally this wouldn't be needed - was able to get rid of it on v1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -306,7 +304,8 @@ async fn handler( | |||
Err(_) => { // Heartbeat, used to detect disconnected clients and then end running tools. | |||
if tx.is_closed() { | |||
// Kill any running processes when the client disconnects | |||
goose::process_store::kill_processes(); | |||
// TODO is this used? I suspect post MCP this is on the server instead | |||
// goose::process_store::kill_processes(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baxen wonder if this caused some process hassles you had earlier?
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
Co-authored-by: Salman Mohammed <[email protected]> Co-authored-by: Wendy Tang <[email protected]> Co-authored-by: Zaki Ali <[email protected]> Co-authored-by: Kalvin Chau <[email protected]> Co-authored-by: Mic Neale <[email protected]>
No description provided.