test: convert Google Gemini tests to VCR #118
Conversation
part of square/exchange#67 closes square/exchange#71 Signed-off-by: Adrian Cole <[email protected]>
|
@baxen I'll move each pending PR from exchange to here one-by-one, here's the first! |
| @@ -128,4 +149,4 @@ def vision(provider_cls: Type[Provider], model: str, **kwargs) -> Tuple[Message, | |||
| content=[ToolResult(tool_use_id="xyz", output='"image:tests/test_image.png"')], | |||
| ), | |||
| ] | |||
| return provider.complete(model=model, system=system, messages=messages, tools=None, **kwargs) | |||
| return provider.complete(model=model, system=system, messages=messages, tools=(), **kwargs) | |||
There was a problem hiding this comment.
There are a lot of IDE warnings about call sites we use, as it is at the moment tools: Tuple[Tool]. So, this clears warnings about passing None. Though I wonder if it shouldn't be tools: Tuple[Tool, ...]? Seems that would be more explicit about possibly none, and also clear some other warnings. If you feel this is worthwhile I can in a follow-up or different PR.
|
:nit: could we format the json so it's easier to read? string: |-
{
"candidates": [
{
"content": { ... }
} |
technically yes, it will require some engineering to write a custom serializer as vcr has no options built-in. I'm not opposed to this, but it also will affect the openai data already here, and could be done as a separate task. Is it ok if we decouple this? You can assign that issue to me which I can try on a weekend or a flight. |
|
@codefromthecrypt sure! just a nit - i just like to know what's being passed in just for learning: is the custom serializer required to dump the request/response to yaml? never used it before so i was naively thinking using a edit: made issue #127, can't seem to assign it - thanks for taking a look! |
* main: feat: add groq provider (#134) feat: add a deep thinking reasoner model (o1-preview/mini) (#68) fix: use concrete SessionNotifier (#135) feat: add guards to session management (#101) fix: Set default model configuration for the Google provider. (#131) test: convert Google Gemini tests to VCR (#118) chore: Add goose providers list command (#116) docs: working ollama for desktop (#125) docs: format and clean up warnings/errors (#120) docs: update deploy workflow (#124) feat: Implement a goose run command (#121)
So, I didn't consider yq (like something we could do in |
part of square/exchange#67 closes square/exchange#71