Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update coverage package #95

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

update coverage package #95

wants to merge 3 commits into from

Conversation

pq
Copy link
Collaborator

@pq pq commented Dec 13, 2019

@pq
Copy link
Collaborator Author

pq commented Dec 13, 2019 •
edited
Loading

This seems to resolve issues I'm seeing in dart-lang/sdk#58086

EDIT: not sure actually. This is working locally but still failing on travis.

@bkonyi
Copy link
Contributor

bkonyi commented Dec 13, 2019

LGTM (I don't have review rights it looks like). Also, while you're here, you might want to remove --checked from travis.sh and replace it with --enable-asserts to get the CI green.

@pq
Copy link
Collaborator Author

pq commented Dec 13, 2019

I'd literally just done exactly that @bkonyi. 😄

Thanks!

@pq pq requested a review from nilsdoehring December 13, 2019 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsdoehring nilsdoehring Awaiting requested review from nilsdoehring

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pq @bkonyi