-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for GraphQL Docs Request for client request, add fix can'… #18
base: master
Are you sure you want to change the base?
Conversation
…t get the InputObject's Parameter bug, and fix the directive does not work well bug.
@@ -230,7 +243,7 @@ __Type = types.object({ | |||
kind = types.list(types.nonNull(__Type)), | |||
resolve = function(kind) | |||
if kind.__type == 'Object' then | |||
return kind.interfaces | |||
return kind.interface or {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this still be .interfaces
?
variableMap[_vn] = true | ||
-- TODO Maybe danger | ||
if not _cv[_vn] then | ||
_cv[_vn] = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This leads to a regression where unused variables don't fail validation anymore, try validating query test($arg: String) {}
.
Any updates on this @yongboy? |
some of the changes are integrated here (PR will come later). https://github.com/ruslantalpa/graphql-lua/tree/deploy the docs work for me |
I'm not sure if this thread is dead, but I've got this working with GraphiQL with the following minimal patch: andyvanee@4785941 Also, I was a bit confused since the only available version on luarocks is the 0.0.2 tag, which is quite old and does not include many of the changes necessary to work with GraphiQL - particularly 119aafe . Perhaps it's time for an updated tag? Thanks! |
Fix bugs:
Docs
failure:))