[PM-15634] Add intermediate Export settings view #1227
Conversation
…when Credential Exchange flag is enabled so the user can decide whether the export to a file or using the Credential Exchange flow.
fedemkr
requested review from
matt-livefront,
phil-livefront,
brant-livefront and
a team
as code owners
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## PM-14800/impl-cxp-import-flow #1227 +/- ##
================================================================
Coverage ? 89.60%
================================================================
Files ? 711
Lines ? 45137
Branches ? 0
================================================================
Hits ? 40445
Misses ? 4692
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
🎨 What do you think about renaming the containing folder from Export to ExportSettings since these files are all using the ExportSettings prefix?
| SettingsListItem(Localizations.exportVaultToAFile) { | ||
| store.send(.exportToFileTapped) | ||
| } trailingContent: { | ||
| chevron | ||
| } | ||
| .accessibilityIdentifier("ExportVaultToAFileLabel") | ||
| .cornerRadius(10) | ||
|
|
||
| SettingsListItem(Localizations.exportVaultToAnotherApp) { | ||
| store.send(.exportToAppTapped) | ||
| } trailingContent: { | ||
| chevron | ||
| } | ||
| .accessibilityIdentifier("ExportVaultToAnotherAppLabel") | ||
| .cornerRadius(10) |
There was a problem hiding this comment.
⛏️ It looks like both of these items are displaying the bottom divider. Should that be removed? Alternatively, should both of these options be grouped together, similar to the main settings view?
| /// A route to the export vault settings view. | ||
| case exportVault |
There was a problem hiding this comment.
⛏️ Slight preference to renaming this to exportSettings to match the prefix for the files associated with this route.
🎟️ Tracking
PM-15634
📔 Objective
Add intermediate Export settings view so that the user can choose whether to export to a file or using the Credential Exchange flow.
Notes
The old "Export vault" view files were moved to another folder, so now we have this structure:
📸 Screenshots
Export.intermediate.view.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes