Spectral averaging with outlier rejection #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Janne98 Can you first make sure that merge conflicts are resolved? |
Done |
bittremieux
requested changes
Nov 15, 2024
| np.ndarray | ||
| The array of intensities with outliers removed. | ||
| """ | ||
| while len(intensities) > 2: |
There was a problem hiding this comment.
thought: Interesting, I didn't know this was performed iteratively. Don't you progressively remove a bunch of peaks that way?
There was a problem hiding this comment.
Yes, this is how they describe it in the paper
There was a problem hiding this comment.
I looked into it a bit further and sigma clipping is an iterative procedure by default, but typically removes only 1 outlier per iteration. However, the paper uses a "bulk rejection" version of sigma clipping to limit the number of calculations (median and std).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to choose consensus spectrum method by setting
--consensus_methodtomedoidoraverage. Ifaverage, spectral averaging with outlier rejection will be performed.