Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New input for installing a specific emulator version #53

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

ofalvai
Copy link
Contributor

@ofalvai ofalvai commented Nov 18, 2024

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a MINOR version update

Context

The emulator SDK package is not versioned and there is no way to sdkmanager --install a specific version, it always installs the latest version.

We regularly update the emulator package to the latest version because of the above. New updates frequently introduce bugs, performance regressions, but also fixes to those regressions, so there is no "good" emulator version, it's better to provide a preinstalled default and let users override it at runtime.

Changes

  • Add a mechanism to download and install a specific version at runtime. This is largely based on the hacky instructions from Google
  • Introduce a new input: emulator_build_number. This could cause a conflict with the existing emulator_channel input, so there is new extra validation for this edge case.
  • Update go-utils and go-steputils (needed because of the newly imported subpackages)
  • Input category cleanups

Investigation details

Decisions

@ofalvai ofalvai closed this Nov 18, 2024
@ofalvai ofalvai reopened this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant