Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Linux installation process on README to have a way to dynamically get kubeseal version number #1294

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

alexjyong
Copy link
Contributor

Description of the change

Updating the README.md to show how to get the version of kubeseal dynamically instead of having to hardcode it for the Linux install script

Benefits

Users don't have to go to the release page to find the latest version

Install script can be used in CI/CD environments or other environments where kubeseal may be dynamically installed and this will allow the version of the latest to be automatically installed

Possible drawbacks

Adds extra detail to the README. I've maintained the original way to do it in the event the user using this doesn't have jq and curl installed, which is required for this method and cannot/does not want to install it.

Applicable issues

N/A

Additional information
N/A

…nstall

docs: updating readme to show how to get kubeseal version dynamically…
Copy link
Collaborator

@alvneiayu alvneiayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvneiayu alvneiayu merged commit 567f679 into bitnami-labs:main Aug 21, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants