Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify LRU stability during warmup #420

Merged
merged 2 commits into from
Nov 11, 2023
Merged

Conversation

bitfaster
Copy link
Owner

@bitfaster bitfaster commented Oct 15, 2023

Previously, items were evicted as the item count approached capacity. This was not expected behavior, items should not be evicted until capacity is reached.

Eliminating the races during Cycle and Cycle warm have made this stable.

@bitfaster bitfaster changed the title warmup Verify LRU stability during warmup Nov 11, 2023
@bitfaster bitfaster marked this pull request as ready for review November 11, 2023 00:14
@coveralls
Copy link

Coverage Status

coverage: 98.598%. first build
when pulling c8c77d0 on users/alexpeck/lruwarmup
into b027a68 on main.

@bitfaster bitfaster merged commit 8b5e246 into main Nov 11, 2023
14 checks passed
@bitfaster bitfaster deleted the users/alexpeck/lruwarmup branch November 11, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants