Extend timeout for mpsc buffer test #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 14, 2023 09:24
|
It could be that this is caused by the timeout attribute:
|
added 2 commits
October 14, 2023 12:15
|
TimeoutAfter taken from here. |
added 3 commits
October 14, 2023 12:29
bitfaster
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the core problem is that xunit will start to heavily parallelize test execution, and the github action runs on a 2 core machine. Previous bug fix PR added two more soak tests, which led to more severe thread starvation. Increasing the timeout makes this much more stable. Next step will be to break out soak tests and not run them in parallel.
[Fact(Timeout=x]because it is documented as undefined behavior when tests are run in parallelTask.TimeoutAfterextension method. This is likely not better, because the real issue is xunit scheduling too many threads.MpscBoundedBuffer