Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dockerfile and docker-compose files #1540

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

arshbot
Copy link
Contributor

@arshbot arshbot commented Mar 5, 2024

Had a ton of issues running this repo locally (macOS 14, apple silicon). Eventually abandoned all effort to run things locally, found the dockerfile.md but still had a bunch of issues related to locales. Whipped up my own dockerfiles, pushing upstream. If the contribution is welcome, I can modify the dockerfile.md file to support this

@arshbot arshbot force-pushed the better-docker-support branch from f682c12 to 7e07647 Compare March 5, 2024 01:57
@arshbot
Copy link
Contributor Author

arshbot commented Mar 5, 2024

hmm, i see the efforts to upgrade ruby from 2.6.x. Once that's wrapped up, I can update this and get this into mergable state

@bitschmidty
Copy link
Contributor

bitschmidty commented Apr 18, 2024

@arshbot thanks and a couple things here. The move to ruby 2.6.x is likely instead a move away from jekyll altogether

That said, if there is improvement to our build system in the meantime in the form of improved docker support, Im for that.

Since we already have a docker file for the repo, we should probably update that one to better handle all usage instead of creating a new one. Im not super familiar with docker and how to parse the diff between the two and what your issue with the original docker file might be, so perhaps you can help me with that (if this is something you want to continue to pursue)

@jonatack jonatack force-pushed the master branch 3 times, most recently from 38028a8 to 9db038c Compare August 26, 2024 20:43
@arshbot
Copy link
Contributor Author

arshbot commented Nov 3, 2024

I don't see another Dockerfile I could've missed, are you perhaps referring to docker.md? This isn't a dockerfile, but rather steps on how to run the project quickly with docker.

I'm aware this sounds similar, but the nuance is important.

In dockerfile.md, you'll see this line (formatted for readability below):

docker run 
-d 
--name bitcoinops 
-p 4000:4000 
-v ${repath}/bitcoinops.github.io:/root/bitcoinops.github.io 
-w /root/bitcoinops.github.io ruby:2.6.4-stretch /bin/bash 
-c "bundle install && make preview"

This line is what I'm improving with a bonafide Dockerfile. The docker run instruction above is (frankly) not going to work for most people, just has a few assumptions and is just a quickly jotted down command.

A Dockerfile is a step of build instructions for the purpose of reproducibility, making sure that it'll always build.

I can amend this dockerfile.md's instructions to reflect the new addition?

@arshbot
Copy link
Contributor Author

arshbot commented Nov 3, 2024

Also, if the project is going in another direction - I wouldn't mind just closing this PR

@bitschmidty
Copy link
Contributor

I can amend this dockerfile.md's instructions to reflect the new addition?

Yeah, that was what I was getting at. I think it is ok to merge then. And we can tackle any updates once the move to hugo is complete.

@arshbot
Copy link
Contributor Author

arshbot commented Nov 4, 2024

Awesome. I ended up reducing the setup steps so much that a dedicated document just no longer made sense. Moved the steps into README where docker was mentioned.

@arshbot arshbot marked this pull request as ready for review November 4, 2024 16:24
@arshbot
Copy link
Contributor Author

arshbot commented Nov 17, 2024

@bitschmidty doesn't look like a reviewer is assigned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants