Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: more accessibility #215

Merged
merged 1 commit into from
Sep 28, 2024
Merged

feat: more accessibility #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions BDKSwiftExampleWallet/Resources/Localizable.xcstrings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,9 @@
}
}
}
},
"%lld satoshis per vbyte" : {

},
"%lld Transaction%@" : {
"localizations" : {
Expand Down Expand Up @@ -251,6 +254,9 @@
}
}
}
},
"Bitcoin Balance" : {

},
"Block %@" : {
"localizations" : {
Expand Down Expand Up @@ -566,6 +572,9 @@
}
}
}
},
"Select Bitcoin Network" : {

},
"Select Fee" : {
"localizations" : {
Expand All @@ -576,6 +585,9 @@
}
}
}
},
"Select Transaction Fee" : {

},
"Send" : {
"localizations" : {
Expand All @@ -586,6 +598,9 @@
}
}
}
},
"Send Transaction" : {

},
"Settings Error" : {
"localizations" : {
Expand Down
1 change: 1 addition & 0 deletions BDKSwiftExampleWallet/View/OnboardingView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ struct OnboardingView: View {
}
.pickerStyle(.automatic)
.tint(.primary)
.accessibilityLabel("Select Bitcoin Network")

Picker(
"Esplora Server",
Expand Down
1 change: 1 addition & 0 deletions BDKSwiftExampleWallet/View/Send/BuildTransactionView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ struct BuildTransactionView: View {

)
.padding()
.accessibilityLabel("Send Transaction")

} else if isSent && viewModel.buildTransactionViewError == nil {
VStack {
Expand Down
5 changes: 5 additions & 0 deletions BDKSwiftExampleWallet/View/Send/FeeView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ struct FeeView: View {

HStack {
Spacer()

Picker("Select Fee", selection: $viewModel.selectedFeeIndex) {
HStack {
Image(
Expand Down Expand Up @@ -70,9 +71,13 @@ struct FeeView: View {
}
.pickerStyle(.automatic)
.tint(.primary)
.accessibilityLabel("Select Transaction Fee")
.accessibilityValue("\(viewModel.selectedFee ?? 1) satoshis per vbyte")

Text("sat/vb")
.foregroundColor(.secondary)
.fontWeight(.thin)

Spacer()
}

Expand Down
3 changes: 3 additions & 0 deletions BDKSwiftExampleWallet/View/WalletView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ struct WalletView: View {
.lineLimit(1)
.minimumScaleFactor(0.5)
}
.accessibilityLabel("Bitcoin Balance")
.accessibilityValue("\(viewModel.balanceTotal.formattedSatoshis()) sats")

HStack {
if viewModel.walletSyncState == .syncing {
Image(systemName: "chart.bar.fill")
Expand Down
Loading