Add _ge_set_all_gej and use it in musig for own public nonces #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sipa
reviewed
Oct 8, 2024
src/group.h
Outdated
| @@ -80,7 +80,10 @@ static void secp256k1_ge_set_gej(secp256k1_ge *r, secp256k1_gej *a); | |||
| /** Set a group element equal to another which is given in jacobian coordinates. */ | |||
| static void secp256k1_ge_set_gej_var(secp256k1_ge *r, secp256k1_gej *a); | |||
|
|
|||
| /** Set a batch of group elements equal to the inputs given in jacobian coordinates */ | |||
| /** Set a batch of group elements equal to the inputs given in jacobian coordinates (affine). Constant time. */ | |||
There was a problem hiding this comment.
Explicitly say that the inputs are not allowed to be infinity?
There was a problem hiding this comment.
rephrased the entire docstring
real-or-random
force-pushed
the
202410-ct-batch-inv
branch
2 times, most recently
from
218ebfb
to
1ba332a
Compare
theStack
reviewed
Oct 9, 2024
real-or-random
force-pushed
the
202410-ct-batch-inv
branch
from
1ba332a
to
f24e3e6
Compare
theStack
approved these changes
Oct 10, 2024
real-or-random
added a commit
that referenced
this pull request
Oct 22, 2024
…once points 57eda3b musig: ctimetests: fix _declassify range for generated nonce points (Sebastian Falbesoner) Pull request description: As noticed in #1614 (comment), the area marked as non-secret exceeds the nonce_pts array in the second iteration of the for loop. Fix that by passing the correct size to the _declassify call. ACKs for top commit: sipa: utACK 57eda3b real-or-random: utACK 57eda3b Tree-SHA512: ff8074e3d1078d66a52d08c661997856ff586b3b4564a865a75212b32fafd7906d58885371bd63005007fde554ebcad121ab66125abe4331cf0aac63fc018ed0
This is a dump mechanical translation of secp256k1_ge_set_all_gej_var that assumes that inputs are not infinity.
No semantic changes.
real-or-random
force-pushed
the
202410-ct-batch-inv
branch
from
f24e3e6
to
64228a6
Compare
|
rebased, ready for review again |
theStack
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #1479 (comment)