Revert fix for wm 2023 and remove unused code #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaagut
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
In this comment (bit-bots/bitbots_vision#343 (comment)) I said, we would record an image appr. every 2.5 seconds. However, the launch default was 1 Hz and also the hard-coded settings in the vision suggested 1 Hz. I guess, it's our choice now, what we want: 1 Hz, 2.5 Hz, or something else?
|
I think 1Hz is a round number |
|
Yes, it certainly is! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As we have a solution for ros2/rmw_cyclonedds#461, we can revert the republishing as described in #266. The fix is also in the ansible and should be deployed to the robots. I also deleted some related unused code.
Still needs testing on the robot.
Related issues
Closes #266
Checklist
colcon build