Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix heterogeneous testcase and rebuild samples #244

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

divarvel
Copy link
Collaborator

@divarvel divarvel commented Nov 12, 2024

  • the heterogeneous equals sample had an issue, and the readme.md / samples.json files had not been regenerated
  • the array/map sample description has been edited for consistency

Code coverage checks are a bit finicky

Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #244 will not alter performance

Comparing fix-heterogeneous-equals-sample (3930767) with v5 (e59f41d)

Summary

✅ 12 untouched benchmarks

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.03%. Comparing base (d90accd) to head (3930767).
Report is 4 commits behind head on v5.

Additional details and impacted files
@@            Coverage Diff             @@
##               v5     #244      +/-   ##
==========================================
+ Coverage   68.96%   69.03%   +0.07%     
==========================================
  Files          25       25              
  Lines        5922     5926       +4     
==========================================
+ Hits         4084     4091       +7     
+ Misses       1838     1835       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@divarvel divarvel force-pushed the fix-heterogeneous-equals-sample branch 2 times, most recently from 106d8c7 to 0846798 Compare November 12, 2024 09:37
It is not v5 blocks, it’s v6 blocks, and other v6 samples don’t mention the block version (samples will later be split by minimum datalog version)
@divarvel divarvel force-pushed the fix-heterogeneous-equals-sample branch from d56c311 to 3930767 Compare November 12, 2024 09:52
@divarvel divarvel merged commit c7f53f7 into v5 Nov 12, 2024
7 checks passed
@divarvel divarvel deleted the fix-heterogeneous-equals-sample branch November 12, 2024 09:59
@divarvel divarvel mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant