Support for closures

[divarvel]

The goal of this branch is to explore how to add support for closures in the stack machine

• closures are represented as a list of ops and a list of parameter names

• closure parameters can be used like variables

• variable names must be unique, so shadowing is forbidden

• boolean operators use laziness and push the rhs closure on the ops list only if needed (without recursion)

• .any() and .all() use recursion to compute results

• closure support in datalog::expression::Op

• closure support in format::schema

• closure support in parser

• closures for lazy boolean operators

• closures for .any() and .all()

• prevent shadowing in closure arguments

  • evaluation
  • parsing & deserialization depends on feat: detect free variables in rule expressions #179 will be done in a dedicated PR

• print And and Or with &&! and ||!, without parsing them.

• v5 block detection depends on Add HeterogeneousEqual and HeterogeneousNotEqual to binary operation #220

[codspeed-hq]

CodSpeed Performance Report

Merging #202 will not alter performance

_{Comparing closures (6fe9bfd) with v5 (3e3f071)}

Summary

✅ 12 untouched benchmarks

[codecov]

Codecov Report

Attention: Patch coverage is 88.65546% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 68.57%. Comparing base (3e3f071) to head (6fe9bfd).

Files	Patch %	Lines
biscuit-auth/src/format/convert.rs	85.55%	13 Missing ⚠️
biscuit-auth/src/datalog/expression.rs	92.75%	5 Missing ⚠️
biscuit-parser/src/builder.rs	0.00%	5 Missing ⚠️
biscuit-auth/src/token/builder.rs	80.00%	3 Missing ⚠️
biscuit-auth/src/datalog/mod.rs	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               v5     #202      +/-   ##
==========================================
+ Coverage   67.91%   68.57%   +0.66%     
==========================================
  Files          25       25              
  Lines        5507     5681     +174     
==========================================
+ Hits         3740     3896     +156     
- Misses       1767     1785      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Geal]

great job!