-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow providing a custom setting file, overriding the default setting… #201
Conversation
Build artifacts:
|
Works fine, but I note the folder must be in the cloned repo to be included in the Docker mount. Due to this I think it would be best to prescribe a folder and add it to the .gitignore - see #202 |
Yeah, good point. Not sure if adding it to git ignore is going to be enough of a hint as to where to put it, so we could either add an empty skeleton Folder |
Yea I'll expand the documentation when this is all merged
This creates the directory Then build using... |
There could be some debate on directory naming and structure |
…to-gitignore Prescribe user settings folder
Build artifacts:
|
@hyp0dermik-code This for example would have been a PR where I would have rather squashed the commits since the addition of the user folder is rather to be seen as a part of the "main feature" of this PR and and a commit just for that seems like overkill. (just for reference, no harm done ;-) |
…s at build time #142
No functional change. Resulting hex files are byte compatible to base branch.