Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow providing a custom setting file, overriding the default setting… #201

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

stylesuxx
Copy link
Contributor

…s at build time #142

No functional change. Resulting hex files are byte compatible to base branch.

Copy link

Build artifacts:

@hyp0dermik-code
Copy link
Contributor

Works fine, but I note the folder must be in the cloned repo to be included in the Docker mount. Due to this I think it would be best to prescribe a folder and add it to the .gitignore - see #202

@stylesuxx
Copy link
Contributor Author

Yeah, good point. Not sure if adding it to git ignore is going to be enough of a hint as to where to put it, so we could either add an empty skeleton Folder CustomSettings with a short *md file or expand the documentation accordingly.

@hyp0dermik-code
Copy link
Contributor

Yeah, good point. Not sure if adding it to git ignore is going to be enough of a hint as to where to put it, so we could either add an empty skeleton Folder CustomSettings with a short *md file or expand the documentation accordingly.

Yea I'll expand the documentation when this is all merged
I was thinking of simply:

mkdir user
cp -rf /src/Settings/ user/

This creates the directory user/Settings where you can edit settings accordingly.
The user directory is ignored by Git

Then build using...

@hyp0dermik-code
Copy link
Contributor

There could be some debate on directory naming and structure

…to-gitignore

Prescribe user settings folder
Copy link

Build artifacts:

@hyp0dermik-code hyp0dermik-code merged commit 2ea7ddd into develop Jul 24, 2024
1 check passed
@stylesuxx
Copy link
Contributor Author

@hyp0dermik-code This for example would have been a PR where I would have rather squashed the commits since the addition of the user folder is rather to be seen as a part of the "main feature" of this PR and and a commit just for that seems like overkill.

(just for reference, no harm done ;-)

@hyp0dermik-code hyp0dermik-code deleted the feature/142-setting-override branch July 24, 2024 09:26
@hyp0dermik-code hyp0dermik-code added this to the v0.21.1 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants