Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sys bio model fixes #154

Merged
merged 7 commits into from
Oct 4, 2024
Merged

Sys bio model fixes #154

merged 7 commits into from
Oct 4, 2024

Conversation

CodeByDrescher
Copy link
Contributor

@CodeByDrescher CodeByDrescher commented Oct 4, 2024

Fixes more problems found in Sys-bio models, including:

  • Using MathML style references to biological concepts when performing ModelAttributeChanges

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.81%. Comparing base (8218c5b) to head (0f5be30).
Report is 10 commits behind head on dev.

Files with missing lines Patch % Lines
biosimulators_utils/sedml/utils.py 89.83% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #154      +/-   ##
==========================================
- Coverage   88.83%   88.81%   -0.02%     
==========================================
  Files          89       89              
  Lines        9635     9668      +33     
==========================================
+ Hits         8559     8587      +28     
- Misses       1076     1081       +5     
Flag Coverage Δ
unittests 88.81% <90.62%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7 Security Hotspots

See analysis details on SonarCloud

@CodeByDrescher CodeByDrescher merged commit e0fe4eb into dev Oct 4, 2024
10 of 11 checks passed
@CodeByDrescher CodeByDrescher deleted the sys-bio-model-fixes branch October 4, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant