Gradient Boosting - Remove try/catch around imports #6584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
boosting-remove-imports
branch
2 times, most recently
from
130bbcf to
297ec2c
Compare
|
Come on, let's wait a bit with this so that we see if the added requirements create problems for anyone. I am making this a draft. |
|
/rebase |
PrimozGodec
force-pushed
the
boosting-remove-imports
branch
from
7ad0e49 to
3364ea4
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6584 +/- ##
==========================================
- Coverage 88.07% 88.05% -0.02%
==========================================
Files 322 322
Lines 70254 70226 -28
==========================================
- Hits 61874 61841 -33
- Misses 8380 8385 +5 |
PrimozGodec
force-pushed
the
boosting-remove-imports
branch
from
637f695 to
55f4965
Compare
PrimozGodec
force-pushed
the
boosting-remove-imports
branch
from
dc080ec to
360b7b3
Compare
|
I think it can be reviewed and merged now. |
|
I'd wait with this a little bit now that newest xgboost version started not packing libomp again. Perhaps we should even think about dropping the requirement... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
After #6570, try/catch around xgboost/catboost methods is not required anymore since packages are always installed
Description of changes
Remove try/catch around imports, skips in tests, and simplify parts of the code.
This PR also fix translations since the check is currently failing on the master.
Includes