-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Color styled widget icons #271
Conversation
After checkout, these branch icons are oversized (see screenshot below). My setup is a laptop with a retina screen and an external "normal" screen plugged in. Everything is fine when I open Orange on the retina or only use an external screen. The problem happens when both screens are on, and I open orange on the external screen. |
Is this happening using Qt6? |
Yes, I have PyQt6. I can also try it later on PyQt5. |
The color is frequently requested from the brush as used in a QPalette.
539ac2a
to
43b52f2
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #271 +/- ##
==========================================
+ Coverage 75.06% 75.30% +0.24%
==========================================
Files 97 99 +2
Lines 20766 20953 +187
==========================================
+ Hits 15588 15779 +191
+ Misses 5178 5174 -4
☔ View full report in Codecov by Sentry. |
Can you check again with the latest version. |
It looks good now. |
Issue
Fixes: gh-270
Changes
Color widget icons based on current palette where appropriate.
By default when running in dark mode the colors are inverted to fit the background to foreground grayscale range.
Note that 'Color' is quite badly drawn.
But also add support for explicitly using palette styled widget icons like in biolab/orange3#6444