Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update (Empanada) 2D Instance Mitochondrial Segmentation in EM Images - 2D MitoNet #730

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

bioimageiobot
Copy link
Collaborator

This is an automatic PR created by the @bioimageiobot regarding changes to the resource item 10.5281/zenodo.10391887.
The following version(s) will be added:

Please review the changes and make sure the new item or version(s) pass the following check list:

  • Passed the bioimage.io CI tests: static (and dynamic) validations
  • The meta information for the RDF item is complete
    • The tags are complete and describe the model
    • Naming is intuitive and descriptive, example: Multi-Organ Nucleus Segmentation (StarDist 2D)
    • Authors are provided
    • Documentation is complete
      • For models, include an overview, describe how the model is trained, what is the training data, how to use the model, how to validate the results and list the references. TODO: Model documentation template.
  • Approved by at least one of the bioimage.io admin team member.

Maintainers: @abhishek-bhardwaj-IN

Note: If you updated or re-uploaded another version for the current item on Zenodo, this PR won't be changed automatically. To proceed, you can do the following:

  1. Block this version, but keep looking for future versions: Edit the current resource.yaml and keep the top-level status field as accepted, but change the status under the current version to blocked.
  2. Accept this version and keep looking for future versions: Merge this PR for now.
  3. Keep proposed version(s) (and this resource in general if it is new) as pending: Close this PR without merging.

Then wait for the CI on the main branch to complete. It should detect the new version(s) and create another PR for the new version(s).

Previous PRs of this resource: #696

@bioimageiobot
Copy link
Collaborator Author

preview

@FynnBe FynnBe merged commit 6415648 into main Apr 23, 2024
8 of 9 checks passed
@FynnBe FynnBe deleted the auto-update-10.5281/zenodo.10391887 branch April 23, 2024 22:37
@abhishek-bhardwaj-IN
Copy link

@FynnBe I see this PR is merged, but the empanada model is still not available on bioimage.io website. Can you please help with this?

@FynnBe
Copy link
Member

FynnBe commented Apr 30, 2024

hi @abhishek-bhardwaj-IN
first of all thank you for this contribution to the model zoo and your patience!
As we are moving to a new backend I have uploaded your model to our new backend directly: https://uk1s3.embassy.ebi.ac.uk/public-datasets/bioimage.io/patient-owl/staged/1/files/bioimageio.yaml

@FynnBe
Copy link
Member

FynnBe commented Apr 30, 2024

the tests run atm here

@FynnBe
Copy link
Member

FynnBe commented May 1, 2024

unfortunately tests don't pass, I'll try to take a look at fixing the model soon.
In the meantime you can try to make the tests pass yourself using bioimageio.core==0.6.2

from bioimageio.core import test_description, save_bioimageio_package_as_folder

local = save_bioimageio_package_as_folder("patient-owl/staged/1", output_path="patient-owl-local")

summary = test_description(local)
summary.display()

Also I would highly recommend to avoid the model kwarg to Empanada2DInference. Why can these not be set after initialization via nn_module.load_state_dict()?

@abhishek-bhardwaj-IN
Copy link

@FynnBe Thanks for looking into it.
Right now its not possible to remove model from kwarg as that will require major refactoring, but it's on our list for upcoming release. Can we proceed as it is now? Also, I am attaching the empanada-bioimage zip file which passes the above test pipeline.

https://abhibhardwaj-my.sharepoint.com/:u:/g/personal/abhishek_abhibhardwaj_in/Ec05ARkUWv9PuZ2BlZCAE5ABojMixMs2WldiPX-pjWaUbQ?e=vrElpM

@FynnBe
Copy link
Member

FynnBe commented May 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants