Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

megahit: add linux-aarch64 build #46803

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Conversation

martin-g
Copy link
Contributor

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@martin-g
Copy link
Contributor Author

martin-g commented Mar 27, 2024

@mencian mencian added the aarch64 Related to adding linux-aarch64 support label Mar 28, 2024
@martin-g
Copy link
Contributor Author

martin-g commented Apr 4, 2024

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Azure

Package(s) built on Azure are ready for inspection:

Arch Package Zip File
linux-64 megahit-1.2.9-h43eeafb_5.tar.bz2 LinuxArtifacts

You may also use conda to install these after downloading and extracting the appropriate zip file. From the LinuxArtifacts or OSXArtifacts directories:

conda install -c ./packages <package name>

Docker image(s) built (images for Azure are in the LinuxArtifacts zip file above):

Package Tag Install with docker
megahit 1.2.9--h43eeafb_5
showgzip -dc LinuxArtifacts/images/megahit:1.2.9--h43eeafb_5.tar.gz | docker load

CircleCI

Package(s) built on CircleCI are ready for inspection:

Arch Package Repodata
linux-aarch64 megahit-1.2.9-hf1d9491_5.tar.bz2 repodata.json

You may also use conda to install these:

conda install -c https://output.circle-artifacts.com/output/job/695ebd31-1274-4662-b227-8f71a7e26e44/artifacts/0/tmp/artifacts/packages <package name>

@martin-g
Copy link
Contributor Author

martin-g commented Apr 4, 2024


mgrigorov in 🌐 euler-arm-22 in /tmp/megahit took 10s 
❯ tar jxvf megahit-1.2.9-hf1d9491_5.tar.bz2 
info/run_exports.json
info/test/run_test.sh
info/recipe/build.sh
info/hash_input.json
info/index.json
info/files
info/recipe/meta.yaml.template
info/recipe/linux-aarch64-support-pr-368.patch
info/recipe/meta.yaml
info/paths.json
info/recipe/conda_build_config.yaml
info/about.json
info/licenses/LICENSE
info/git
bin/megahit_toolkit
bin/megahit
bin/megahit_core
bin/megahit_core_no_hw_accel
bin/megahit_core_popcnt
share/megahit/test_data/generate_random_fasta.py
share/megahit/test_data/r1.il.fa.gz
share/megahit/test_data/r4.fa
share/megahit/test_data/loop.fa
share/megahit/test_data/ref.fa
share/megahit/test_data/r3_1.fa
share/megahit/test_data/r3_2.fa
share/megahit/test_data/empty.fa
share/megahit/test_data/r2.il.fa.bz2

mgrigorov in 🌐 euler-arm-22 in /tmp/megahit 
❯ file bin/*
bin/megahit:                  Python script, ASCII text executable
bin/megahit_core:             ELF 64-bit LSB pie executable, ARM aarch64, version 1 (GNU/Linux), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, with debug_info, not stripped
bin/megahit_core_no_hw_accel: ELF 64-bit LSB pie executable, ARM aarch64, version 1 (GNU/Linux), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, with debug_info, not stripped
bin/megahit_core_popcnt:      ELF 64-bit LSB pie executable, ARM aarch64, version 1 (GNU/Linux), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, with debug_info, not stripped
bin/megahit_toolkit:          symbolic link to megahit_core_no_hw_accel

mgrigorov in 🌐 euler-arm-22 in /tmp/megahit 
❯ ./bin/megahit_core
Usage: ./bin/megahit_core <sub_program> [sub options]
    sub-programs:
       assemble       assemble from SdBG
       local          local asssembly
       iterate        extract iterative edges
       buildlib       build read library
       count          kmer counting
       read2sdbg      build sdbg from reads
       seq2sdbg       build sdbg from megahit contigs + edges
       contig2fastg   convert MEGAHIT's k*.contigs.fa to fastg format
       readstat       calculate read stats (# of reads, bases, longest, shortest, average)
       filterbylen    filter contigs by length
       checkcpu       check whether the run-time CPU supports POPCNT and BMI2
       checkpopcnt    check whether the run-time CPU supports POPCNT
       checkbmi2      check whether the run-time CPU supports BMI2
       dumpversion    dump version
       kmax           the largest k value supported

LGTM!

@martin-g
Copy link
Contributor Author

martin-g commented Apr 4, 2024

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Apr 4, 2024
@mencian
Copy link
Contributor

mencian commented Apr 4, 2024

Thanks @martin-g!

@mencian mencian closed this Apr 4, 2024
@mencian mencian reopened this Apr 4, 2024
@mencian mencian merged commit 840cb4b into bioconda:master Apr 4, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch64 Related to adding linux-aarch64 support please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants