Refactor downloader #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmughal
force-pushed
the
21-downloader-refactor
branch
from
3317e93 to
bfb5f4d
Compare
zmughal
commented
Mar 7, 2024
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
- This creates a temporary BioBricks configuration. - Fixes bug where if the user running tests has an existing `.biobricks` configuration, it gets overwritten. - Reads initial token from either environment variable or existing BioBricks config file if exists.
tomlue
force-pushed
the
21-downloader-refactor
branch
2 times, most recently
from
6de735d to
1a602d1
Compare
Fixes #21. Refactored brick.py to check if an out exists and report errors when it does not. This allows a brick to be installed even if some files are missing on s3. Implemented a parallel downloader in dvc_fetcher.py.
tomlue
force-pushed
the
21-downloader-refactor
branch
from
1a602d1 to
410c0b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.