Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore check for vehicle finder remote service #643

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

rikroe
Copy link
Member

@rikroe rikroe commented Aug 3, 2024

Proposed change

Don't check if vehicleFinder is active before triggering the remote service.
On older cars, this capability is returned as false but vehicle finder still works.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this library)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works.

@rikroe rikroe merged commit d23660f into bimmerconnected:master Aug 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant