Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIB-64: Fix 'ArgumentError: wrong number of arguments (given 1, expected 0)' #2588

Open
wants to merge 2 commits into
base: BIB-46-dual-boot-with-rails-7-1
Choose a base branch
from
Open

BIB-64: Fix 'ArgumentError: wrong number of arguments (given 1, expected 0)' #2588

wants to merge 2 commits into from

Conversation

torresga
Copy link
Contributor

@torresga torresga commented Oct 2, 2024 •
edited
Loading

This PR fixes the following test failures that are found in Rails 7.1:

ArgumentError:
  wrong number of arguments (given 1, expected 0)
/home/circleci/.cache/bundle/ruby/2.7.0/gems/activesupport-7.1.4/lib/active_support/core_ext/object/with.rb:24:in `with'

We found this issue in rspec-mocks rspec/rspec-mocks#1530 so we decided to update rspec and its' dependencies.

@torresga torresga changed the base branch from main to BIB-46-dual-boot-with-rails-7-1 October 2, 2024 20:53
@torresga torresga changed the title Bib 64 fix argumenterror with BIB-64: Fix 'ArgumentError: wrong number of arguments (given 1, expected 0)' Oct 2, 2024
@mateusdeap mateusdeap marked this pull request as ready for review October 8, 2024 13:09
mateusdeap
mateusdeap approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@mateusdeap mateusdeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mateusdeap mateusdeap requested review from sethherr and removed request for sethherr October 8, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateusdeap mateusdeap mateusdeap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torresga @mateusdeap