BIB-46: Dual boot with Rails 7.1 #2581
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…order to dual boot both rails
…ated and removed in Rails 7
torresga
commented
Sep 6, 2024
| @@ -149,7 +159,7 @@ GEM | |||
| brakeman (5.4.1) | |||
| buftok (0.2.0) | |||
| builder (3.3.0) | |||
| bullet (7.0.1) | |||
| bullet (7.1.6) | |||
There was a problem hiding this comment.
Upgrade bullet for Rails 7.1 support: https://github.com/flyerhzm/bullet/blob/main/CHANGELOG.md#710-10062023
So we can start work on Rails 7.1 upgrade. What - Update gemfiles and lock files. - Ensure CI runs tests for both versions. - Update incompatible gems. Jira: https://ombulabs.atlassian.net/browse/BIB-46
fbuys
force-pushed
the
BIB-46-dual-boot-with-rails-7-1
branch
from
45d2fb1
to
f9b5d0a
Compare
torresga
force-pushed
the
BIB-46-dual-boot-with-rails-7-1
branch
from
1d56154
to
0d597ae
Compare
torresga
commented
Oct 8, 2024
| @@ -185,7 +195,12 @@ GEM | |||
| crass (1.0.6) | |||
| css_parser (1.7.1) | |||
| addressable | |||
| database_cleaner (1.7.0) | |||
| database_cleaner (2.0.2) | |||
There was a problem hiding this comment.
We updated database_cleaner because we were getting this error in Rails 7.1:
An error occurred in a `before(:suite)` hook.
Failure/Error: DatabaseCleaner.clean_with(:deletion)
NoMethodError:
undefined method `table_name' for ActiveRecord::SchemaMigration:Class
# ./spec/rails_helper.rb:161:in `block (2 levels) in <top (required)>'
mateusdeap
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the dual boot code to dual boot both Rails 7.0 and Rails 7.1 locally and in CI.
Running rails c and rails s should work as expected with no errors.
The CI should run the tests for Rails 7.1.
You can append
BUNDLE_GEMFILE=Gemfile.nextto a command, i.e.BUNDLE_GEMFILE=Gemfile.next rails cto run whatever command using Rails 7.1.We will continue to fix the broken build in Rails 7.1 in upcoming PRs.