Upgrade bootstrap gem #2063
Open
Upgrade bootstrap gem #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: this isn't that simple - see #1005 for the start. There are A BUNCH of style changes between the version of bootstrap that we have and Also, the way we want to move forward is via webpacker (we have bootstrap 4.3.1 in If this gem blocks upgrading other important things, the easy way forward is to vendor the exact version of bootstrap that is used ( |
|
Yup, didn't think it would be. Consider this PR an experiment to see what breaks where. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.