Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Endpoint for retrieving all transcripts for a given HGNC ID (#11) #12

Merged
merged 4 commits into from
Oct 15, 2023
Merged

feat: Endpoint for retrieving all transcripts for a given HGNC ID (#11) #12

merged 4 commits into from
Oct 15, 2023

Conversation

gromdimon
Copy link
Contributor

@gromdimon gromdimon commented Oct 13, 2023 •
edited
Loading

Issue: #11

@gromdimon gromdimon linked an issue Oct 13, 2023 that may be closed by this pull request
Implement endpoint for retrieving all transcripts for a given HGNC ID #11
Closed
@gromdimon gromdimon changed the title feat:Endpoint for retrieving all transcripts for a given HGNC ID (#11) feat: Endpoint for retrieving all transcripts for a given HGNC ID (#11) Oct 13, 2023
@gromdimon gromdimon requested a review from holtgrewe October 13, 2023 15:15
@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5f82241) 80.64% compared to head (87476c4) 85.38%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   80.64%   85.38%   +4.73%     
==========================================
  Files           4        4              
  Lines         124      171      +47     
==========================================
+ Hits          100      146      +46     
- Misses         24       25       +1
Files Coverage Δ
dotty/main.py 96.55% <97.87%> (+1.55%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@holtgrewe
some fixes / adjustments to patch
87476c4 
- uing pytest_snapshot to simplify tests
- using proper .pyi additions rather than mypy warning skips
- adjusting structure of pydantic models a bit
@holtgrewe
Copy link
Member

@gromdimon thanks I took the liberty to perform some code adjustments and use pytest_snapshot to simplify the tests.

Also note how I adjusted the .pyi files rather than using mypy ignores.

@holtgrewe holtgrewe enabled auto-merge (squash) October 15, 2023 07:21
@holtgrewe holtgrewe merged commit 2b425bf into main Oct 15, 2023
7 checks passed
holtgrewe
holtgrewe reviewed Oct 15, 2023
View reviewed changes
Copy link
Member

@holtgrewe holtgrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some changes, see my patch and comment

@holtgrewe holtgrewe deleted the 11-implement-endpoint-for-retrieving-all-transcripts-for-a-given-hgnc-id branch October 15, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holtgrewe holtgrewe holtgrewe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement endpoint for retrieving all transcripts for a given HGNC ID
2 participants
@gromdimon @holtgrewe