Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update Python versions we test against. #215

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ jobs:
matrix:
python-version:
- '3.10'
# - "3.11" # no compatible pysam yet
# - "3.12" # no compatible pysam yet
- '3.11'
- '3.12'
needs: linting
steps:
- name: Install Python via conda
Expand Down
6 changes: 2 additions & 4 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,8 @@ def parse_requirements(path):
"Topic :: Scientific/Engineering :: Bio-Informatics",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.10",
# We are missing bioconda pysam packages for 3.11 and 3.12, cf.
# https://github.com/bioconda/bioconda-recipes/issues/37805
# "Programming Language :: Python :: 3.11",
# "Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
],
entry_points={"console_scripts": ("cubi-tk = cubi_tk.__main__:main",)},
description="Tooling for connecting GitLab, pipelines, and SODAR at CUBI.",
Expand Down
4 changes: 1 addition & 3 deletions tests/test_seasnap_itransfer_results.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def test_run_seasnap_itransfer_results_nothing(capsys):
assert res.err


def test_run_seasnap_itransfer_results_smoke_test(mocker):
def test_run_seasnap_itransfer_results_smoke_test(mocker, fs):
# --- setup arguments
dest_path = "/irods/dest"
fake_base_path = "/base/path"
Expand All @@ -57,7 +57,6 @@ def test_run_seasnap_itransfer_results_smoke_test(mocker):

# Setup fake file system but only patch selected modules. We cannot use the Patcher approach here as this would
# break biomedsheets.
fs = fake_filesystem.FakeFilesystem()
fake_os = fake_filesystem.FakeOsModule(fs)
fake_pl = fake_pathlib.FakePathlibModule(fs)

Expand All @@ -83,7 +82,6 @@ def test_run_seasnap_itransfer_results_smoke_test(mocker):
fs.remove(fake_file_paths[3])

# --- mock modules
mocker.patch("glob.os", fake_os)
mocker.patch("cubi_tk.sea_snap.itransfer_results.pathlib", fake_pl)
mocker.patch("cubi_tk.sea_snap.itransfer_results.os", fake_os)
mocker.patch("cubi_tk.snappy.itransfer_common.os", fake_os)
Expand Down
Loading