Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mscoco transformations to BigML-COCO and documentation changes #261

Merged
merged 14 commits into from
Jun 13, 2024
Merged

Conversation

mmerce
Copy link
Member

@mmerce mmerce commented Jun 12, 2024

Includes the #258 changes and adds checks and tests.

@mmerce mmerce requested a review from jaor June 12, 2024 19:07
@jaor jaor self-assigned this Jun 12, 2024
Copy link
Member

@jaor jaor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just a few typos and nits

README.rst Outdated
c:\Python27\python.exe distribute_setup.py

After that, you'll be able to install ``pip`` by typing the following command
To install BigMLer on Windows environments, you'll Python installed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: you'll need

README.rst Outdated

After that, you'll be able to install ``pip`` by typing the following command
To install BigMLer on Windows environments, you'll Python installed.
The code has been tested with Python 3.10 and you can create a conda
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe make "conda" italics if it's usually spelled lowercase? or maybe not, if everybody knows wthat that is..

README.rst Outdated
To install BigMLer on Windows environments, you'll Python installed.
The code has been tested with Python 3.10 and you can create a conda
environment with that Python version or download it from `Python for Windows
<http://www.python.org/download/>`_ and install it. In the last case, you'll
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the latter case

README.rst Outdated
.. code-block:: bash

c:\Python27\Scripts\easy_install.exe pip
To install ``pip``, first you need to open your command line window
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a command line terminal window (?)

@@ -180,6 +164,11 @@ issuing

should show BigMLer version information.

Extensions of BigMLer to use images are not supported in Windows by default.
The libraries needed for those models are not available usually for that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are usually not available

" the corresponding annotations, unless some "
" folder attribute is provided in each"
" annotation. In that case it should point to"
" the folder parent directory and --anotations-dir"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

folder's

" the corresponding annotations, unless some "
" folder attribute is provided in each"
" annotation. In that case it should point to"
" the folder parent directory and --anotations-dir"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

folder's (IIUC)

filenames = voc_to_cocojson(args.annotations_dir, args, session_file)
elif args.annotations_language == "YOLO":
filenames = yolo_to_cocojson(args.annotations_dir, args, session_file)
elif args.annotations_language == "COCO":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am neutral about it, but have you considered naming it MSCOCO to be explicit about its not being pure COCO? or is it the case that the only COCO is MSCOCO?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though so too, but COCO is shorter and from what I saw is most common.

@jaor jaor merged commit 85c7e16 into master Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants