-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mscoco transformations to BigML-COCO and documentation changes #261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, just a few typos and nits
README.rst
Outdated
c:\Python27\python.exe distribute_setup.py | ||
|
||
After that, you'll be able to install ``pip`` by typing the following command | ||
To install BigMLer on Windows environments, you'll Python installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: you'll need
README.rst
Outdated
|
||
After that, you'll be able to install ``pip`` by typing the following command | ||
To install BigMLer on Windows environments, you'll Python installed. | ||
The code has been tested with Python 3.10 and you can create a conda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe make "conda" italics if it's usually spelled lowercase? or maybe not, if everybody knows wthat that is..
README.rst
Outdated
To install BigMLer on Windows environments, you'll Python installed. | ||
The code has been tested with Python 3.10 and you can create a conda | ||
environment with that Python version or download it from `Python for Windows | ||
<http://www.python.org/download/>`_ and install it. In the last case, you'll |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the latter case
README.rst
Outdated
.. code-block:: bash | ||
|
||
c:\Python27\Scripts\easy_install.exe pip | ||
To install ``pip``, first you need to open your command line window |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a command line terminal window (?)
@@ -180,6 +164,11 @@ issuing | |||
|
|||
should show BigMLer version information. | |||
|
|||
Extensions of BigMLer to use images are not supported in Windows by default. | |||
The libraries needed for those models are not available usually for that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are usually not available
bigmler/options/source.py
Outdated
" the corresponding annotations, unless some " | ||
" folder attribute is provided in each" | ||
" annotation. In that case it should point to" | ||
" the folder parent directory and --anotations-dir" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
folder's
bigmler/options/source.py
Outdated
" the corresponding annotations, unless some " | ||
" folder attribute is provided in each" | ||
" annotation. In that case it should point to" | ||
" the folder parent directory and --anotations-dir" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
folder's (IIUC)
filenames = voc_to_cocojson(args.annotations_dir, args, session_file) | ||
elif args.annotations_language == "YOLO": | ||
filenames = yolo_to_cocojson(args.annotations_dir, args, session_file) | ||
elif args.annotations_language == "COCO": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am neutral about it, but have you considered naming it MSCOCO to be explicit about its not being pure COCO? or is it the case that the only COCO is MSCOCO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I though so too, but COCO is shorter and from what I saw is most common.
Includes the #258 changes and adds checks and tests.