Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Live updates UI refactor #5

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

GuiLeme
Copy link
Collaborator

@GuiLeme GuiLeme commented Aug 14, 2024

What does this PR do?

Refactors in general:

  • Fix Performance issues and some memory leaks that we previously had;
  • Fix UI's bad performance (scroll container kept flickering with children updated);
  • Refactors UI's live-update overview with a zoom-in/out feature to focus on specific student (now it's a grid);
  • Adds a pagination feature to the new grid (next step would be to make the maximum number of live-updates per page customizable - which it is already dynamically set);
  • General code refactor to make it more readable;
  • Makes h5p-standalone to render an iframe instead of a div in live-update feature;
  • Change the deploy script to also include customized CSS.

More

See demonstration video below:

better-grid-view-demo-h5p-live-updates.mp4

Copy link

@Arthurk12 Arthurk12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments below. Other than that, the PR looks great!

package.json Outdated Show resolved Hide resolved
@GuiLeme GuiLeme requested a review from Arthurk12 September 12, 2024 12:44
Copy link

@Arthurk12 Arthurk12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antobinary antobinary merged commit b7bab85 into bigbluebutton:main Sep 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants