Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use specific commit from theme repo #178

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Nimrais
Copy link
Collaborator

@Nimrais Nimrais commented Aug 25, 2023

Improving Workflow: Introducing a new update command to streamline theme changes. This enhancement removes the requirement for superficial commits when adjusting the theme, ensuring code integrity and reducing unnecessary access to the theme's repo.

@albertpod
Copy link
Collaborator

Why?

@Nimrais
Copy link
Collaborator Author

Nimrais commented Aug 25, 2023

@albertpod I don't believe it's good practice to modify code behind the scenes. Currently, if we only want to change the theme and not the site content, we're forced to make a superficial commit that doesn't alter any line in this repository but still modifies the site. I'm working on a new update command that will allow changes to the commit without accessing the theme's repo.

@Nimrais
Copy link
Collaborator Author

Nimrais commented Aug 25, 2023

So the update-theme actions actually will be documented, they will change the commit hash.

@Nimrais Nimrais self-assigned this Aug 25, 2023
@Nimrais Nimrais marked this pull request as draft August 25, 2023 14:09
@bvdmitri
Copy link
Member

bvdmitri commented Aug 25, 2023

we're forced to make a superficial commit that doesn't alter any line in this repository

why? can't you just re-trigger the deployment of the website?

@bvdmitri
Copy link
Member

@Nimrais I'm pretty much sure you can just run publish.sh after a change in the theme and there is no need for any superficial commits in the repository.

@Nimrais
Copy link
Collaborator Author

Nimrais commented Aug 26, 2023

@bvdmitri Yes, you can 100%. And that is exactly the problem. We are deploying from this repo smt that in any sense controlled by this repo.

@Nimrais Nimrais marked this pull request as ready for review August 28, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants