Updating tools/flexynesis from version 0.2.10 to 0.2.12 #1563
+48
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nilchia is that ok? |
|
@bgruening No I have to add XGBoost and fix some tests. Working on it. |
|
@bgruening Can you please give me access to this repo so I can push my changes? |
|
Done. But please note, that you can always push to your repo and make a PR against the bot repo or a new PR. |
|
Thanks! |
add XGBoost and tests
|
Yes it is! |
bgruening
reviewed
Jan 8, 2025
| <has_text_matching expression="DirectPred,Erlotinib,numerical,mse,"/> | ||
| <has_text_matching expression="DirectPred,Erlotinib,numerical,r2,"/> | ||
| <has_text_matching expression="DirectPred,Erlotinib,numerical,pearson_corr,"/> | ||
| <has_text_matching expression="GNN,Erlotinib,numerical,mse,"/> |
There was a problem hiding this comment.
Why did it change from DirectPred to GNN?
There was a problem hiding this comment.
This one is correct actually. In the previous test <param name="model_class" value="GNN"/> was not enclosed within the <conditional name="model_class"> and </conditional>, and instead of GNN, the default model (DirectPred) was called.
The other tests are correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This is an automated update of the following tool: tools/flexynesis. I created this PR because I think the tool's main dependency is out of date, i.e. there is a newer version available through conda.
I have updated tools/flexynesis from version 0.2.10 to 0.2.12.
Project home page: https://github.com/BIMSBbioinfo/flexynesis/tree/main/releases
For any comments, queries or criticism about the bot, not related to the tool being updated in this PR, please create an issue here.
If you want to skip this change, close this PR without deleting the branch. It will be reopened if another change is detected.
Any commit from another author than 'planemo-autoupdate' will prevent more auto-updates.
To ignore manual changes and allow autoupdates, delete the branch.