-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PTM Dephosphorylation Predictation Tool #1525
base: master
Are you sure you want to change the base?
Conversation
@haibkhn thanks for the PR. I will have a look and provide my feedback |
Here are a few obvious comments to start with:
ping @haibkhn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a .shed.yml file
tools/prot_tools/optuna_tool.xml
Outdated
@@ -0,0 +1,339 @@ | |||
<tool id="hyperparameter_finetune" name="Hyperparameter Search for Finetuning model" version="1.0.0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<tool id="hyperparameter_finetune" name="Hyperparameter Search for Finetuning model" version="1.0.0"> | |
<tool id="hyperparameter_finetune" name="Hyperparameter Search for Finetuning model" version="1.0.0" profile="23.0"> |
I think while testing, the script tries to download the LLM (ProtT5-XL-UniRef50) having a size > 10 GB. It could be the reason CI/CD throws an error related to the memory It could be possible to provide a remote link to the model but I think HuggingFace does not allow the model from remote. The models should be hosted at HuggingFace, correct? @haibkhn Moving to a container-based tool might help but not sure. Can the HuggingFace table used with the Flux tool might help? ping @bgruening @arash77 Thanks! |
I don't think that it is possible to test the tool completely with the models in GitHub if the model is big. unless there is a smaller version of the model available. |
This pull request introduces a new tool for predicting dephosphorylation. Key features include:
Two modes of operation:
Support for 3 protein language model variations:
Additional hyperparameter search option:
@anuprulez Please review these changes and let me know if any modifications are needed.