Add biotools xref to MAFFT #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bebatut
reviewed
Oct 31, 2023
tools/mafft/macros.xml
Outdated
| @@ -2,6 +2,11 @@ | |||
| <macros> | |||
| <token name="@VERSION@">0</token> | |||
There was a problem hiding this comment.
It would be good to increate the wrapper version there
There was a problem hiding this comment.
Exactly what I was asking Paul. I was in a dilemma given nothing else changes.
There was a problem hiding this comment.
Yes I agree. But having the biotools means that EDAM annotations can be extracted and used for finding the tool in Galaxy and in the tool panel. But for that, it needs a new version. Does that make sense?
|
Results of the pre-existing test #3 passes varies from execution to execution if multi-threading is used. By default it passes during local testing (GALAXY_SLOTS=1), whereas GH testing routing uses 2 threads. Updated the checks to tolerate such differences between different iterations. |
bgruening
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.