Skip to content

Commit

Permalink
Merge pull request #1235 from bghira/bugfix/tensorboard-sana-arg
Browse files Browse the repository at this point in the history
remove sana complex human instruction from tensorboard args (#1234)
  • Loading branch information
bghira authored Dec 19, 2024
2 parents 7815be2 + 57de333 commit c6cdbb0
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions helpers/training/trainer.py
Original file line number Diff line number Diff line change
Expand Up @@ -1620,6 +1620,7 @@ def init_trackers(self):
delattr(public_args, "weight_dtype")
delattr(public_args, "base_weight_dtype")
delattr(public_args, "vae_kwargs")
delattr(public_args, "sana_complex_human_instruction")

# Hash the contents of public_args to reflect a deterministic ID for a single set of params:
public_args_hash = hashlib.md5(
Expand Down

1 comment on commit c6cdbb0

@DefinitlyEvil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value should be one of int, float, str, bool, or torch.Tensor
Traceback (most recent call last):
  File "./SimpleTuner/train.py", line 70, in <module>
    trainer.init_trackers()
  File "./SimpleTuner/helpers/training/trainer.py", line 1632, in init_trackers
    self.accelerator.init_trackers(
  File "/opt/miniconda3/envs/simpletuner/lib/python3.11/site-packages/accelerate/accelerator.py", line 708, in _inner
    return PartialState().on_main_process(function)(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/miniconda3/envs/simpletuner/lib/python3.11/site-packages/accelerate/accelerator.py", line 2654, in init_trackers
    tracker.store_init_configuration(config)
  File "/opt/miniconda3/envs/simpletuner/lib/python3.11/site-packages/accelerate/tracking.py", line 79, in execute_on_main_process
    return PartialState().on_main_process(function)(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/miniconda3/envs/simpletuner/lib/python3.11/site-packages/accelerate/tracking.py", line 211, in store_init_configuration
    self.writer.add_hparams(values, metric_dict={})
  File "/opt/miniconda3/envs/simpletuner/lib/python3.11/site-packages/torch/utils/tensorboard/writer.py", line 330, in add_hparams
    exp, ssi, sei = hparams(hparam_dict, metric_dict, hparam_domain_discrete)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/miniconda3/envs/simpletuner/lib/python3.11/site-packages/torch/utils/tensorboard/summary.py", line 318, in hparams
    raise ValueError(
ValueError: value should be one of int, float, str, bool, or torch.Tensor

Hi, great work!
Any idea what this might be? I upgraded from previous installation.
Thx.

Please sign in to comment.